[uss_qualifier] extract some fragments for scenarios injecting flights #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
net0320-factor-out-injection
branch
2 times, most recently
from
ac45c2d to
de8dd57
Compare
mickmis
reviewed
Jan 21, 2025
|
|
||
| ## 🛑 Identifiable flights check | ||
|
|
||
| This particular test requires each flight to be uniquely identifiable by its 2D telemetry position; the same (lat, lng) pair may not appear in two different telemetry points, even if the two points are in different injected flights. This should generally be achieved by injecting appropriate data. |
There was a problem hiding this comment.
Not within scope of this PR: No requirement specified here?
There was a problem hiding this comment.
I did not design the original test, so I'm not sure.
Possibly the scenario could check this and abort/skip the run if the condition is not met instead?
monitoring/uss_qualifier/scenarios/astm/netrid/v19/fragments/sp_polling.md
Show resolved
Hide resolved
Shastick
force-pushed
the
net0320-factor-out-injection
branch
2 times, most recently
from
15f8daf to
8e5aad2
Compare
Shastick
force-pushed
the
net0320-factor-out-injection
branch
from
8e5aad2 to
bfcc4f4
Compare
mickmis
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#880 will add a scenario that does some flight injections, and we start to have some duplicated steps and checks.
This PR proposes to move common steps and checks to their own fragment.